diff options
author | Jeff King <peff@peff.net> | 2020-07-28 22:21:52 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-07-29 00:02:17 +0200 |
commit | 819f0e76b110458488c41741b0dcd538483848c0 (patch) | |
tree | 19dadce2b11898856e1a2a06666ee97be3ca04af /generate-cmdlist.sh | |
parent | Git 2.28 (diff) | |
download | git-819f0e76b110458488c41741b0dcd538483848c0.tar.xz git-819f0e76b110458488c41741b0dcd538483848c0.zip |
argv-array: use size_t for count and alloc
On most 64-bit platforms, "int" is significantly smaller than a size_t,
which could lead to integer overflow and under-allocation of the array.
It's probably impossible to trigger in practice, as it would imply on
the order of 2^32 individual allocations. Even if was possible to grow
an array in that way (and we typically only use it for sets of strings,
like command line options), each allocation needs a pointer, malloc
overhead, etc. You'd quite likely run out of RAM before succeeding in
such an overflow.
But all that hand-waving aside, it's easy enough to use the correct
type, so let's do so.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'generate-cmdlist.sh')
0 files changed, 0 insertions, 0 deletions