diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2010-02-22 09:46:33 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-02-22 23:19:28 +0100 |
| commit | 8c33b4cf67f47ee46fe0984751fd40c4cf7cf392 (patch) | |
| tree | 6d9e4d65b289b81558de3a57f9adc16a979742d6 /git-sh-setup.sh | |
| parent | t7006-pager: if stdout is not a terminal, make a new one (diff) | |
| download | git-8c33b4cf67f47ee46fe0984751fd40c4cf7cf392.tar.xz git-8c33b4cf67f47ee46fe0984751fd40c4cf7cf392.zip | |
tests: Fix race condition in t7006-pager
Pagers that do not consume their input are dangerous: for example,
$ GIT_PAGER=: git log
$ echo $?
141
$
The only reason these tests were able to work before was that
'git log' would write to the pipe (and not fill it) before the
pager had time to terminate and close the pipe.
Fix it by using a program that consumes its input, namely wc (as
suggested by Johannes).
Reported-by: Johannes Sixt <j.sixt@viscovery.net>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-sh-setup.sh')
0 files changed, 0 insertions, 0 deletions