summaryrefslogtreecommitdiffstats
path: root/gpg-interface.h
diff options
context:
space:
mode:
authorPatrick Steinhardt <ps@pks.im>2024-08-19 09:48:02 +0200
committerJunio C Hamano <gitster@pobox.com>2024-08-21 20:33:02 +0200
commit51a0b8a2a70f78f157761b3629010399463ed982 (patch)
tree52d1299f19faa3aa4f2fd68a0964cb118b3211d1 /gpg-interface.h
parentt7900: fix flaky test due to leaking background job (diff)
downloadgit-51a0b8a2a70f78f157761b3629010399463ed982.tar.xz
git-51a0b8a2a70f78f157761b3629010399463ed982.zip
t7900: exercise detaching via trace2 regions
In t7900, we exercise the `--detach` logic by checking whether the command ended up writing anything to its output or not. This supposedly works because we close stdin, stdout and stderr when daemonizing. But one, it breaks on platforms where daemonize is a no-op, like Windows. And second, that git-maintenance(1) outputs anything at all in these tests is a bug in the first place that we'll fix in a subsequent commit. Introduce a new trace2 region around the detach which allows us to more explicitly check whether the detaching logic was executed. This is a much more direct way to exercise the logic, provides a potentially useful signal to tracing logs and also works alright on platforms which do not have the ability to daemonize. Signed-off-by: Patrick Steinhardt <ps@pks.im> [jc: dropped a stale in-code comment from a test] Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'gpg-interface.h')
0 files changed, 0 insertions, 0 deletions