summaryrefslogtreecommitdiffstats
path: root/reftable
diff options
context:
space:
mode:
authorPatrick Steinhardt <ps@pks.im>2024-10-17 06:53:45 +0200
committerTaylor Blau <me@ttaylorr.com>2024-10-17 22:59:55 +0200
commit409f04995e6ede838576fb795cf45dc6f10ab508 (patch)
tree89a13d5b9d4bdc63b029b3047ccb124bb85de9fb /reftable
parentStart the 2.48 cycle (diff)
downloadgit-409f04995e6ede838576fb795cf45dc6f10ab508.tar.xz
git-409f04995e6ede838576fb795cf45dc6f10ab508.zip
reftable: stop using `strbuf_addbuf()`
We're about to introduce our own `reftable_buf` type to replace `strbuf`. Get rid of the seldomly-used `strbuf_addbuf()` function such that we have to reimplement one less function. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Taylor Blau <me@ttaylorr.com>
Diffstat (limited to 'reftable')
-rw-r--r--reftable/block.c2
-rw-r--r--reftable/record.c6
-rw-r--r--reftable/writer.c7
3 files changed, 8 insertions, 7 deletions
diff --git a/reftable/block.c b/reftable/block.c
index 8d41a2f99e..cd4180eac7 100644
--- a/reftable/block.c
+++ b/reftable/block.c
@@ -60,7 +60,7 @@ static int block_writer_register_restart(struct block_writer *w, int n,
w->next += n;
strbuf_reset(&w->last_key);
- strbuf_addbuf(&w->last_key, key);
+ strbuf_add(&w->last_key, key->buf, key->len);
w->entries++;
return 0;
}
diff --git a/reftable/record.c b/reftable/record.c
index 30d563e16d..87157f2c38 100644
--- a/reftable/record.c
+++ b/reftable/record.c
@@ -1031,7 +1031,7 @@ static void reftable_index_record_key(const void *r, struct strbuf *dest)
{
const struct reftable_index_record *rec = r;
strbuf_reset(dest);
- strbuf_addbuf(dest, &rec->last_key);
+ strbuf_add(dest, rec->last_key.buf, rec->last_key.len);
}
static int reftable_index_record_copy_from(void *rec, const void *src_rec,
@@ -1041,7 +1041,7 @@ static int reftable_index_record_copy_from(void *rec, const void *src_rec,
const struct reftable_index_record *src = src_rec;
strbuf_reset(&dst->last_key);
- strbuf_addbuf(&dst->last_key, &src->last_key);
+ strbuf_add(&dst->last_key, src->last_key.buf, src->last_key.len);
dst->offset = src->offset;
return 0;
@@ -1085,7 +1085,7 @@ static int reftable_index_record_decode(void *rec, struct strbuf key,
int n = 0;
strbuf_reset(&r->last_key);
- strbuf_addbuf(&r->last_key, &key);
+ strbuf_add(&r->last_key, key.buf, key.len);
n = get_var_int(&r->offset, &in);
if (n < 0)
diff --git a/reftable/writer.c b/reftable/writer.c
index b032a47dec..031d8149a9 100644
--- a/reftable/writer.c
+++ b/reftable/writer.c
@@ -225,7 +225,7 @@ static int writer_index_hash(struct reftable_writer *w, struct strbuf *hash)
*key = empty;
strbuf_reset(&key->hash);
- strbuf_addbuf(&key->hash, hash);
+ strbuf_add(&key->hash, hash->buf, hash->len);
tree_insert(&w->obj_index_tree, key,
&obj_index_tree_node_compare);
} else {
@@ -256,7 +256,7 @@ static int writer_add_record(struct reftable_writer *w,
}
strbuf_reset(&w->last_key);
- strbuf_addbuf(&w->last_key, &key);
+ strbuf_add(&w->last_key, key.buf, key.len);
if (!w->block_writer) {
err = writer_reinit_block_writer(w, reftable_record_type(rec));
if (err < 0)
@@ -778,7 +778,8 @@ static int writer_flush_nonempty_block(struct reftable_writer *w)
index_record.offset = w->next;
strbuf_reset(&index_record.last_key);
- strbuf_addbuf(&index_record.last_key, &w->block_writer->last_key);
+ strbuf_add(&index_record.last_key, w->block_writer->last_key.buf,
+ w->block_writer->last_key.len);
w->index[w->index_len] = index_record;
w->index_len++;