diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-09-01 01:18:11 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-09-02 18:16:24 +0200 |
commit | ac350155de34767e132b383fb1b819ff74e23842 (patch) | |
tree | ef71b903ff1f68e18d0ef68ce620a720f5ecf5fd /repository.h | |
parent | submodule--helper update: don't override 'checkout' exit code (diff) | |
download | git-ac350155de34767e132b383fb1b819ff74e23842.tar.xz git-ac350155de34767e132b383fb1b819ff74e23842.zip |
submodule--helper: libify "must_die_on_failure" code paths (for die)
Continue the libification of codepaths that previously relied on
"must_die_on_failure". In these cases we've always been early aborting
by calling die(), but as we know that these codepaths will properly
handle return codes of 128 to mean an early abort let's have them use
die_message() instead.
This still isn't a complete migration away from die() for these
codepaths, in particular this code in update_submodule() will still call die() in some cases:
char *remote_name = get_default_remote_submodule(update_data->sm_path);
const char *branch = remote_submodule_branch(update_data->sm_path);
But as that code is used by other callers than the "update" code let's
leave converting it for a subsequent commit.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'repository.h')
0 files changed, 0 insertions, 0 deletions