diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-06-11 11:19:17 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-06-11 22:15:04 +0200 |
| commit | 56931c4d89e7efe41dd96d230b8176e2d32a035d (patch) | |
| tree | 9b962b62bef2de8f4deaa61150668b082101ea14 /revision.c | |
| parent | Merge branch 'ps/leakfixes' into ps/leakfixes-more (diff) | |
| download | git-56931c4d89e7efe41dd96d230b8176e2d32a035d.tar.xz git-56931c4d89e7efe41dd96d230b8176e2d32a035d.zip | |
revision: fix memory leak when reversing revisions
When reversing revisions in a rev walk, `get_revision()` will allocate a
new commit list and assign it to `revs->commits`. It does not free the
old list though, which makes it leak. Fix this.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/revision.c b/revision.c index 7ddf0f151a..af95502d92 100644 --- a/revision.c +++ b/revision.c @@ -4430,6 +4430,7 @@ struct commit *get_revision(struct rev_info *revs) reversed = NULL; while ((c = get_revision_internal(revs))) commit_list_insert(c, &reversed); + free_commit_list(revs->commits); revs->commits = reversed; revs->reverse = 0; revs->reverse_output_stage = 1; |