diff options
author | Jiang Xin <zhiyou.jx@alibaba-inc.com> | 2022-06-17 12:03:09 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-06-17 19:38:26 +0200 |
commit | b4eda05d58ca3e4808d3d86ab5826c77995a06f7 (patch) | |
tree | 6d81aafbc779766cc5a5ec91e176b6597bae20e9 /submodule-config.c | |
parent | Another batch of fixes before -rc1 (diff) | |
download | git-b4eda05d58ca3e4808d3d86ab5826c77995a06f7.tar.xz git-b4eda05d58ca3e4808d3d86ab5826c77995a06f7.zip |
i18n: fix mismatched camelCase config variables
Some config variables are combinations of multiple words, and we
typically write them in camelCase forms in manpage and translatable
strings. It's not easy to find mismatches for these camelCase config
variables during code reviews, but occasionally they are identified
during localization translations.
To check for mismatched config variables, I introduced a new feature
in the helper program for localization[^1]. The following mismatched
config variables have been identified by running the helper program,
such as "git-po-helper check-pot".
Lowercase in manpage should use camelCase:
* Documentation/config/http.txt: http.pinnedpubkey
Lowercase in translable strings should use camelCase:
* builtin/fast-import.c: pack.indexversion
* builtin/gc.c: gc.logexpiry
* builtin/index-pack.c: pack.indexversion
* builtin/pack-objects.c: pack.indexversion
* builtin/repack.c: pack.writebitmaps
* commit.c: i18n.commitencoding
* gpg-interface.c: user.signingkey
* http.c: http.postbuffer
* submodule-config.c: submodule.fetchjobs
Mismatched camelCases, choose the former:
* Documentation/config/transfer.txt: transfer.credentialsInUrl
remote.c: transfer.credentialsInURL
[^1]: https://github.com/git-l10n/git-po-helper
Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule-config.c')
-rw-r--r-- | submodule-config.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/submodule-config.c b/submodule-config.c index 51ecbe901e..c2ac7e7bf3 100644 --- a/submodule-config.c +++ b/submodule-config.c @@ -302,7 +302,7 @@ int parse_submodule_fetchjobs(const char *var, const char *value) { int fetchjobs = git_config_int(var, value); if (fetchjobs < 0) - die(_("negative values not allowed for submodule.fetchjobs")); + die(_("negative values not allowed for submodule.fetchJobs")); return fetchjobs; } |