diff options
| author | Jeff King <peff@peff.net> | 2023-01-18 21:36:22 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-01-18 21:59:44 +0100 |
| commit | ad5dfeac040c16057a23f341408d229656e42ab4 (patch) | |
| tree | efdbea0b4a2d8c192261ea9e795276cc69f44c4a /t/t7031-verify-tag-signed-ssh.sh | |
| parent | t1006: stop using 0-padded timestamps (diff) | |
| download | git-ad5dfeac040c16057a23f341408d229656e42ab4.tar.xz git-ad5dfeac040c16057a23f341408d229656e42ab4.zip | |
t7030: stop using invalid tag name
We intentionally invalidate the signature of a tag by switching its tag
name from "seventh" to "7th forged". However, the latter is not a valid
tag name because it contains a space. This doesn't currently affect the
test, but we're better off using something syntactically valid. That
reduces the number of possible failure modes in the test, and
future-proofs us if git hash-object gets more picky about its input.
The t7031 script, which was mostly copied from t7030, has the same
problem, so we'll fix it, too.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t7031-verify-tag-signed-ssh.sh')
| -rwxr-xr-x | t/t7031-verify-tag-signed-ssh.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t7031-verify-tag-signed-ssh.sh b/t/t7031-verify-tag-signed-ssh.sh index 1cb36b9ab8..36eb86a4b1 100755 --- a/t/t7031-verify-tag-signed-ssh.sh +++ b/t/t7031-verify-tag-signed-ssh.sh @@ -125,7 +125,7 @@ test_expect_success GPGSSH,GPGSSH_VERIFYTIME 'verify-tag failes with tag date ou test_expect_success GPGSSH 'detect fudged ssh signature' ' test_config gpg.ssh.allowedSignersFile "${GPGSSH_ALLOWED_SIGNERS}" && git cat-file tag seventh-signed >raw && - sed -e "/^tag / s/seventh/7th forged/" raw >forged1 && + sed -e "/^tag / s/seventh/7th-forged/" raw >forged1 && git hash-object -w -t tag forged1 >forged1.tag && test_must_fail git verify-tag $(cat forged1.tag) 2>actual1 && grep "${GPGSSH_BAD_SIGNATURE}" actual1 && |