diff options
| author | Jacob Keller <jacob.keller@gmail.com> | 2020-08-15 02:25:08 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-08-17 19:39:21 +0200 |
| commit | 95e7c385393488cb20c29697d8655f94ce83c413 (patch) | |
| tree | 2ff928e09a57dc3ddf3f7e4abb30a37cd1de9abb /transport.c | |
| parent | refspec: fix documentation referring to refspec_item (diff) | |
| download | git-95e7c385393488cb20c29697d8655f94ce83c413.tar.xz git-95e7c385393488cb20c29697d8655f94ce83c413.zip | |
refspec: make sure stack refspec_item variables are zeroed
A couple of functions that used struct refspec_item did not zero out the
structure memory. This can result in unexpected behavior, especially if
additional parameters are ever added to refspec_item in the future. Use
memset to ensure that unset structure members are zero.
It may make sense to convert most of these uses of struct refspec_item
to use either struct initializers or refspec_item_init_or_die. However,
other similar code uses memset. Converting all of these uses has been
left as a future exercise.
Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport.c')
| -rw-r--r-- | transport.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/transport.c b/transport.c index 2d4fd851dc..419be0b6ea 100644 --- a/transport.c +++ b/transport.c @@ -443,6 +443,7 @@ void transport_update_tracking_ref(struct remote *remote, struct ref *ref, int v if (ref->status != REF_STATUS_OK && ref->status != REF_STATUS_UPTODATE) return; + memset(&rs, 0, sizeof(rs)); rs.src = ref->name; rs.dst = NULL; |