diff options
author | Patrick Steinhardt <ps@pks.im> | 2022-12-01 15:46:49 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-12-09 06:26:21 +0100 |
commit | 48050c42c73c28b0c001d63d11dffac7e116847b (patch) | |
tree | fbea2ce85a3b749345fd987b13277e8f7ab26e00 /utf8.h | |
parent | pretty: fix adding linefeed when placeholder is not expanded (diff) | |
download | git-48050c42c73c28b0c001d63d11dffac7e116847b.tar.xz git-48050c42c73c28b0c001d63d11dffac7e116847b.zip |
pretty: fix integer overflow in wrapping format
The `%w(width,indent1,indent2)` formatting directive can be used to
rewrap text to a specific width and is designed after git-shortlog(1)'s
`-w` parameter. While the three parameters are all stored as `size_t`
internally, `strbuf_add_wrapped_text()` accepts integers as input. As a
result, the casted integers may overflow. As these now-negative integers
are later on passed to `strbuf_addchars()`, we will ultimately run into
implementation-defined behaviour due to casting a negative number back
to `size_t` again. On my platform, this results in trying to allocate
9000 petabyte of memory.
Fix this overflow by using `cast_size_t_to_int()` so that we reject
inputs that cannot be represented as an integer.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'utf8.h')
0 files changed, 0 insertions, 0 deletions