diff options
author | Werner Koch <wk@gnupg.org> | 2022-06-14 11:33:27 +0200 |
---|---|---|
committer | Werner Koch <wk@gnupg.org> | 2022-06-14 11:34:17 +0200 |
commit | 34c649b3601383cd11dbc76221747ec16fd68e1b (patch) | |
tree | 9a2d774311fbba604263f19c1a489ed6efcc5afc /g10/cpr.c | |
parent | keygen: Fix reading AEAD preference (diff) | |
download | gnupg2-34c649b3601383cd11dbc76221747ec16fd68e1b.tar.xz gnupg2-34c649b3601383cd11dbc76221747ec16fd68e1b.zip |
g10: Fix garbled status messages in NOTATION_DATA
* g10/cpr.c (write_status_text_and_buffer): Fix off-by-one
--
Depending on the escaping and line wrapping the computed remaining
buffer length could be wrong. Fixed by always using a break to
terminate the escape detection loop. Might have happened for all
status lines which may wrap.
GnuPG-bug-id: T6027
Diffstat (limited to 'g10/cpr.c')
-rw-r--r-- | g10/cpr.c | 13 |
1 files changed, 4 insertions, 9 deletions
@@ -372,20 +372,15 @@ write_status_text_and_buffer (int no, const char *string, } first = 0; } - for (esc=0, s=buffer, n=len; n && !esc; s++, n--) + for (esc=0, s=buffer, n=len; n; s++, n--) { if (*s == '%' || *(const byte*)s <= lower_limit || *(const byte*)s == 127 ) esc = 1; if (wrap && ++count > wrap) - { - dowrap=1; - break; - } - } - if (esc) - { - s--; n++; + dowrap=1; + if (esc || dowrap) + break; } if (s != buffer) es_fwrite (buffer, s-buffer, 1, statusfp); |