lib/resolve answer_finalize: fix AD flag handling

Resolves a FIXME, and this way of doing AD should be better/safer.
(Lower likelihood of accidentally leaving it on in some situation.)

GC test: the record is inserted manually with _SECURE rank but without
signatures.  I think it's better to return AD flag in that edge case.

1 files changed, 43 insertions, 43 deletions

diff --git a/utils/cache_gc/test.integr/val_rrsig.rpl b/utils/cache_gc/test.integr/val_rrsig.rpl
index 28c77ac3..22002b78 100644
--- a/utils/cache_gc/test.integr/val_rrsig.rpl
+++ b/utils/cache_gc/test.integr/val_rrsig.rpl
@@ -13,7 +13,7 @@ ENTRY_END
 STEP 2 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -30,7 +30,7 @@ ENTRY_END
 STEP 4 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -47,7 +47,7 @@ ENTRY_END
 STEP 6 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -64,7 +64,7 @@ ENTRY_END
 STEP 8 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -81,7 +81,7 @@ ENTRY_END
 STEP 10 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -98,7 +98,7 @@ ENTRY_END
 STEP 12 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -115,7 +115,7 @@ ENTRY_END
 STEP 14 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -132,7 +132,7 @@ ENTRY_END
 STEP 16 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -149,7 +149,7 @@ ENTRY_END
 STEP 18 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -166,7 +166,7 @@ ENTRY_END
 STEP 20 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -183,7 +183,7 @@ ENTRY_END
 STEP 22 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -200,7 +200,7 @@ ENTRY_END
 STEP 24 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -217,7 +217,7 @@ ENTRY_END
 STEP 26 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -234,7 +234,7 @@ ENTRY_END
 STEP 28 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -251,7 +251,7 @@ ENTRY_END
 STEP 30 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -268,7 +268,7 @@ ENTRY_END
 STEP 32 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -285,7 +285,7 @@ ENTRY_END
 STEP 34 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -302,7 +302,7 @@ ENTRY_END
 STEP 36 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -319,7 +319,7 @@ ENTRY_END
 STEP 38 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -336,7 +336,7 @@ ENTRY_END
 STEP 40 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -353,7 +353,7 @@ ENTRY_END
 STEP 42 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -370,7 +370,7 @@ ENTRY_END
 STEP 44 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -387,7 +387,7 @@ ENTRY_END
 STEP 46 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -404,7 +404,7 @@ ENTRY_END
 STEP 48 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -421,7 +421,7 @@ ENTRY_END
 STEP 50 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -438,7 +438,7 @@ ENTRY_END
 STEP 52 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -455,7 +455,7 @@ ENTRY_END
 STEP 54 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -472,7 +472,7 @@ ENTRY_END
 STEP 56 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -489,7 +489,7 @@ ENTRY_END
 STEP 58 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -506,7 +506,7 @@ ENTRY_END
 STEP 60 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -523,7 +523,7 @@ ENTRY_END
 STEP 62 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -540,7 +540,7 @@ ENTRY_END
 STEP 64 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -557,7 +557,7 @@ ENTRY_END
 STEP 66 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -574,7 +574,7 @@ ENTRY_END
 STEP 68 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -591,7 +591,7 @@ ENTRY_END
 STEP 70 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -608,7 +608,7 @@ ENTRY_END
 STEP 72 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -625,7 +625,7 @@ ENTRY_END
 STEP 74 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -642,7 +642,7 @@ ENTRY_END
 STEP 76 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -659,7 +659,7 @@ ENTRY_END
 STEP 78 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -676,7 +676,7 @@ ENTRY_END
 STEP 80 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -693,7 +693,7 @@ ENTRY_END
 STEP 82 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -710,7 +710,7 @@ ENTRY_END
 STEP 84 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER
@@ -727,7 +727,7 @@ ENTRY_END
 STEP 86 CHECK_ANSWER
 ENTRY_BEGIN
 MATCH opcode rcode flags question answer
-REPLY QR RD RA DO NOERROR
+REPLY QR RD RA AD DO NOERROR
 SECTION QUESTION
 www.example.com. IN A
 SECTION ANSWER