| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
In particular this turns off those debug logs by default.
|
|\
| |
| |
| |
| | |
This is the last commit in `6.0` before it is shifted into `master`,
with 5.x support being moved to `master-5`.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit makes lots of changes to the C code to appease the
Clang-Tidy linter. Some of the less obvious ones are due to C's weird
semantics regarding handling of numeric literals.
We also disable a bunch of the detections because they are
super-pedantic, arguably useless, or we have our own unwritten coding
style rules that solve the issues.
|
|\| |
|
| | |
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
Picked up old work, rebase-squashed after many months;
then fixed up a little as needed in this newer version.
(and later many minor fixes got squashed in)
|
|/ |
|
| |
|
|
|
|
| |
Fixes CIDs 355763 and 355764. Also fixes a minor typo.
|
|
|
|
| |
We can always easily add groups when needed.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
It's special: always on and not shown in log_groups() output.
It's been quite a long fight to find how to best deal with such
a special case (from user perspective; code itself is easy).
|
| |
|
|
|
|
|
|
|
|
|
|
| |
* improve order
- follow grouping of topics more closely (targets, groups, levels)
- order kr_log_LEVEL by severity
* move unneeded <stdarg.h>
* improve doc-comments
- some claims there were even wrong now
- describe some log levels at kr_log_LEVEL
|
|
|
|
|
| |
Let's be consistent witk kr_log_name2level()
and even generally we tend to use negative numbers for errors.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's a non-standard feature of syslog.h and I don't think it's worth
the trouble.
We didn't really utilize it; someone would have to #define it,
and moreover we would get into problems if this wasn't being done
the same on all places including log.h.
Making the names adapt to the platform would also mean that
config files and docs wouldn't be portable.
Also make kr_log_level2name() return const.
|
| |
|
|
|
|
| |
Use a single call as a setter and getter for log groups.
|
|
|
|
|
| |
Using a single function to get/set values is more consistent with our
existing lua API rather than having two separate set and get functions.
|
|
|
|
|
|
|
| |
- add lua set_log_target() + docs
- default to 'stderr' (manual runs)
- switch to 'syslog' in distro-preconfig.lua
- a few minor tweaks
|
| |
|
|
|
|
|
| |
Probably, it seems "more consistent".
Some defines still don't have it, but I left those.
|
|
|
|
| |
logging
|
| |
|
|
|
|
| |
... and optimize a suspect hot path (through VERBOSE_MSG)
|
|
|
|
|
|
|
|
| |
I think it's an old issue, but why not fix it now.
I believe it's better when these two are "independent".
Removed comment: once upon a time it belonged to auto_free
and similar macros, but somehow it survived various moves.
|
|
|
|
|
|
|
|
|
| |
- unify interactive mode to stdout
- use its own logging group
- elevated log level when the command throws an exception
- don't try detecting that the logs go back into the same console
(yes, in that case you can see some lines twice)
- don't make the binary mode turn off logging
|
|
|
|
|
|
|
|
|
|
| |
It would be yet another condition to check; overall I think the
necessary checks would get too complex to be done in a macro
and therefore copied all over the place.
Note: it's interesting that such a change reduces binary size
by about 3% (on master), and I suspect that speed won't suffer at all
(after that TODO is done).
|
|
|
|
|
|
|
| |
- const for names of log groups
- enum kr_log_group for a single log group
- the kr_log_groups bitmap doesn't need to be exposed or even exported
- return bool instead of int
|
|
|
|
|
|
| |
- ensure gnutls logging can be turned on/off by using GNUTLS log group
- keep TLS / TLSCLIENT as log groups for our TLS logs and use GNUTLS
instead
|
|
|
|
|
|
|
| |
It's better to use separate log group, to separate between logs that
come from the lua module vs native C implementation. It is also more
descriptive, since http modules is used for other stuff besides its
deprecated DoH.
|
| |
|
|
|
|
|
| |
Besides testing the API, running this test also ensures all log groups
have been properly defined (as long as kr_assertions are turned on).
|
| |
|
|
|
|
|
|
|
|
| |
To ensure all log groups have been properly defined, iterate over the
entire enum. If a value is missing, assert will be triggered.
Also fixes groups with number >=32 (32bit value was used to test
whether group is set before).
|
|
|
|
|
|
|
|
|
| |
This serves two purposes:
1. As a utility logger during development.
2. As the last entry in enum - to make iteration over the values
possible. Changing the value of LOG_GRP_DEVEL shouldn't be an issue,
since it shouldn't be used in production code.
|
|
|
|
|
| |
Add space padding when printing the group name to allow usage of
regular group names in lua code (e.g. "io" instead of "io ").
|
|
|
|
|
|
|
|
| |
The function returns a table where key is the group name and the value
is either true (when logging selected group), or nil (when group isn't
selected).
This replaces the list_log_group() which didn't really work.
|
|
|
|
|
|
| |
Ensure both these functions return string that represents the log level.
Also avoid using printf - it'd probably break API when using map().
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|