diff options
author | Matthieu Baerts (NGI0) <matttbe@kernel.org> | 2025-01-08 16:34:32 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2025-01-09 17:53:34 +0100 |
commit | ea62dd1383913b5999f3d16ae99d411f41b528d4 (patch) | |
tree | 414924839cdd9ab6ba6b67991929db5b439a927b /.cocciconfig | |
parent | mptcp: sysctl: blackhole timeout: avoid using current->nsproxy (diff) | |
download | linux-ea62dd1383913b5999f3d16ae99d411f41b528d4.tar.xz linux-ea62dd1383913b5999f3d16ae99d411f41b528d4.zip |
sctp: sysctl: cookie_hmac_alg: avoid using current->nsproxy
As mentioned in a previous commit of this series, using the 'net'
structure via 'current' is not recommended for different reasons:
- Inconsistency: getting info from the reader's/writer's netns vs only
from the opener's netns.
- current->nsproxy can be NULL in some cases, resulting in an 'Oops'
(null-ptr-deref), e.g. when the current task is exiting, as spotted by
syzbot [1] using acct(2).
The 'net' structure can be obtained from the table->data using
container_of().
Note that table->data could also be used directly, as this is the only
member needed from the 'net' structure, but that would increase the size
of this fix, to use '*data' everywhere 'net->sctp.sctp_hmac_alg' is
used.
Fixes: 3c68198e7511 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/67769ecb.050a0220.3a8527.003f.GAE@google.com [1]
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250108-net-sysctl-current-nsproxy-v1-4-5df34b2083e8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions