diff options
| author | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2015-10-20 11:04:05 +0200 |
|---|---|---|
| committer | Jyri Sarha <jsarha@ti.com> | 2016-02-25 15:39:39 +0100 |
| commit | 31ec5a2c7eed3a3e182a592591f4fb04304668a1 (patch) | |
| tree | d9abcead4263cb9d7653a1878b5efd21da5640ad | |
| parent | drm/tilcdc: split reset to a separate function (diff) | |
| download | linux-31ec5a2c7eed3a3e182a592591f4fb04304668a1.tar.xz linux-31ec5a2c7eed3a3e182a592591f4fb04304668a1.zip | |
drm/tilcdc: remove broken error handling
Remove broken error handling. The condition for handling the
LCDC_SYNC_LOST and LCDC_FIFO_UNDERFLOW could never be satisfied as the
LCDC_SYNC_LOST interrupt is not enabled. Also the requirement to have
both LCDC_SYNC_LOST and LCDC_FIFO_UNDERFLOW fired at once before
handling the error looks weird.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
[Added description to the patch]
Signed-off-by: Jyri Sarha <jsarha@ti.com>
| -rw-r--r-- | drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index e62a950b8b76..61aead2ddccb 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -658,12 +658,7 @@ irqreturn_t tilcdc_crtc_irq(struct drm_crtc *crtc) struct tilcdc_drm_private *priv = dev->dev_private; uint32_t stat = tilcdc_read_irqstatus(dev); - if ((stat & LCDC_SYNC_LOST) && (stat & LCDC_FIFO_UNDERFLOW)) { - stop(crtc); - dev_err(dev->dev, "error: %08x\n", stat); - tilcdc_clear_irqstatus(dev, stat); - start(crtc); - } else if (stat & LCDC_PL_LOAD_DONE) { + if (stat & LCDC_PL_LOAD_DONE) { tilcdc_clear_irqstatus(dev, stat); } else { struct drm_pending_vblank_event *event; |