diff options
| author | Imre Deak <imre.deak@intel.com> | 2019-06-28 16:36:35 +0200 |
|---|---|---|
| committer | Imre Deak <imre.deak@intel.com> | 2019-07-01 14:06:35 +0200 |
| commit | 3ee2771e47b038624d68aa051d78ff8558c260b9 (patch) | |
| tree | a502d023a471d47563986010153cc64a95106881 | |
| parent | drm/i915: Remove unneeded disconnect in TypeC legacy port mode (diff) | |
| download | linux-3ee2771e47b038624d68aa051d78ff8558c260b9.tar.xz linux-3ee2771e47b038624d68aa051d78ff8558c260b9.zip | |
drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modes
Lane reversal happens only in the FIA module for TBT-alt/DP-alt mode, so
WARN if lane reversal is attempted at a different level. See the
BSpec DDI_BUF_CTL register description.
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190628143635.22066-24-imre.deak@intel.com
| -rw-r--r-- | drivers/gpu/drm/i915/display/intel_ddi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 8b5350931d16..747b68037fea 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -3604,6 +3604,8 @@ static void intel_ddi_set_fia_lane_count(struct intel_encoder *encoder, u32 val = I915_READ(PORT_TX_DFLEXDPMLE1); bool lane_reversal = dig_port->saved_port_bits & DDI_BUF_PORT_REVERSAL; + WARN_ON(lane_reversal && dig_port->tc_mode != TC_PORT_LEGACY); + val &= ~DFLEXDPMLE1_DPMLETC_MASK(tc_port); switch (pipe_config->lane_count) { case 1: |