diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2023-01-13 10:54:21 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-02-08 09:21:14 +0100 |
| commit | 4d25e97747d3f94c0e8ae9c0da2db801256908d0 (patch) | |
| tree | b18e04e2a357cb4dbad8a75fd1e49e85f466c130 | |
| parent | media: imx-pxp: Introduce pxp_read() and pxp_write() wrappers (diff) | |
| download | linux-4d25e97747d3f94c0e8ae9c0da2db801256908d0.tar.xz linux-4d25e97747d3f94c0e8ae9c0da2db801256908d0.zip | |
media: imx-pxp: Use non-threaded IRQ
There's no need to use threaded IRQs with the PXP, as the interrupt
handler doesn't need to sleep and doesn't perform any time-consuming
operation. Switch to regular IRQ handler.
This fixes lockups of the PXP noticed on i.MX7, where the PXP would stop
generating interrupts after a variable number of frames (from a few
dozens to a few hundreds). The root cause is however unknown.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
| -rw-r--r-- | drivers/media/platform/nxp/imx-pxp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c index cad1a201e1aa..f44cf16be942 100644 --- a/drivers/media/platform/nxp/imx-pxp.c +++ b/drivers/media/platform/nxp/imx-pxp.c @@ -1798,8 +1798,8 @@ static int pxp_probe(struct platform_device *pdev) spin_lock_init(&dev->irqlock); - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, pxp_irq_handler, - IRQF_ONESHOT, dev_name(&pdev->dev), dev); + ret = devm_request_irq(&pdev->dev, irq, pxp_irq_handler, 0, + dev_name(&pdev->dev), dev); if (ret < 0) { dev_err(&pdev->dev, "Failed to request irq: %d\n", ret); return ret; |