diff options
| author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2021-03-12 19:22:25 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-03-18 14:50:35 +0100 |
| commit | ca6b3a6ca047d23b9b2a54af9f7f4d6f41200719 (patch) | |
| tree | 703726b83e273cd13938c2912e24c5c36905dc4c | |
| parent | ASoC: ab8500-codec: remove useless structure (diff) | |
| download | linux-ca6b3a6ca047d23b9b2a54af9f7f4d6f41200719.tar.xz linux-ca6b3a6ca047d23b9b2a54af9f7f4d6f41200719.zip | |
ASoC: ad1836: remove useless return
Cppcheck warning:
sound/soc/codecs/ad1836.c:311:9: warning: Identical condition and return expression 'ret', return value is always 0 [identicalConditionAfterEarlyExit]
return ret;
^
sound/soc/codecs/ad1836.c:308:6: note: If condition 'ret' is true, the function will return/exit
if (ret)
^
sound/soc/codecs/ad1836.c:311:9: note: Returning identical expression 'ret'
return ret;
^
Likely copy/paste between adc and dac cases.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210312182246.5153-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/ad1836.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c index a46152560294..08a5651bed9f 100644 --- a/sound/soc/codecs/ad1836.c +++ b/sound/soc/codecs/ad1836.c @@ -305,8 +305,6 @@ static int ad1836_probe(struct snd_soc_component *component) return ret; ret = snd_soc_dapm_add_routes(dapm, ad183x_adc_routes, num_adcs); - if (ret) - return ret; return ret; } |