diff options
| author | David Gow <davidgow@google.com> | 2024-02-21 10:27:15 +0100 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2024-02-27 23:25:56 +0100 |
| commit | d2733a026fc7247ba42d7a8e1b737cf14bf1df21 (patch) | |
| tree | ae27a973fd63835c4ff8d9026849dd787738a7ff | |
| parent | kunit: test: Log the correct filter string in executor_test (diff) | |
| download | linux-d2733a026fc7247ba42d7a8e1b737cf14bf1df21.tar.xz linux-d2733a026fc7247ba42d7a8e1b737cf14bf1df21.zip | |
lib/cmdline: Fix an invalid format specifier in an assertion msg
The correct format specifier for p - n (both p and n are pointers) is
%td, as the type should be ptrdiff_t.
This was discovered by annotating KUnit assertion macros with gcc's
printf specifier, but note that gcc incorrectly suggested a %d or %ld
specifier (depending on the pointer size of the architecture being
built).
Fixes: 0ea09083116d ("lib/cmdline: Allow get_options() to take 0 to validate the input")
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
| -rw-r--r-- | lib/cmdline_kunit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/cmdline_kunit.c b/lib/cmdline_kunit.c index d4572dbc9145..705b82736be0 100644 --- a/lib/cmdline_kunit.c +++ b/lib/cmdline_kunit.c @@ -124,7 +124,7 @@ static void cmdline_do_one_range_test(struct kunit *test, const char *in, n, e[0], r[0]); p = memchr_inv(&r[1], 0, sizeof(r) - sizeof(r[0])); - KUNIT_EXPECT_PTR_EQ_MSG(test, p, NULL, "in test %u at %u out of bound", n, p - r); + KUNIT_EXPECT_PTR_EQ_MSG(test, p, NULL, "in test %u at %td out of bound", n, p - r); } static void cmdline_test_range(struct kunit *test) |