diff options
author | Waiman Long <longman@redhat.com> | 2024-11-14 19:19:15 +0100 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2024-11-14 19:44:03 +0100 |
commit | fbfbf86685b3270dc27d1c5d6108532334aaf329 (patch) | |
tree | 758929a505dee6300f7a335fec49fa6530ef87b3 /CREDITS | |
parent | cgroup/cpuset: Further optimize code if CONFIG_CPUSETS_V1 not set (diff) | |
download | linux-fbfbf86685b3270dc27d1c5d6108532334aaf329.tar.xz linux-fbfbf86685b3270dc27d1c5d6108532334aaf329.zip |
cgroup/cpuset: Disable cpuset_cpumask_can_shrink() test if not load balancing
With some recent proposed changes [1] in the deadline server code,
it has caused a test failure in test_cpuset_prs.sh when a change
is being made to an isolated partition. This is due to failing
the cpuset_cpumask_can_shrink() check for SCHED_DEADLINE tasks at
validate_change().
This is actually a false positive as the failed test case involves an
isolated partition with load balancing disabled. The deadline check
is not meaningful in this case and the users should know what they
are doing.
Fix this by doing the cpuset_cpumask_can_shrink() check only when loading
balanced is enabled. Also change its arguments to use effective_cpus
for the current cpuset and user_xcpus() as an approiximation for the
target effective_cpus as the real effective_cpus hasn't been fully
computed yet as this early stage.
As the check isn't comprehensive, there may be false positives or
negatives. We may have to revise the code to do a more thorough check
in the future if this becomes a concern.
[1] https://lore.kernel.org/lkml/82be06c1-6d6d-4651-86c9-bcc828cbcb80@redhat.com/T/#t
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions