summaryrefslogtreecommitdiffstats
path: root/Documentation/process/maintainer-netdev.rst
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2023-10-11 04:42:24 +0200
committerDavid S. Miller <davem@davemloft.net>2023-10-15 15:26:51 +0200
commit6e55b1cbf05dca4651692be6c59acb7b20186653 (patch)
tree7137b5e381e1ea0695a8992085aec005a813d405 /Documentation/process/maintainer-netdev.rst
parentMerge branch 'sfc-conntrack-offload' (diff)
downloadlinux-6e55b1cbf05dca4651692be6c59acb7b20186653.tar.xz
linux-6e55b1cbf05dca4651692be6c59acb7b20186653.zip
docs: try to encourage (netdev?) reviewers
Add a section to netdev maintainer doc encouraging reviewers to chime in on the mailing list. The questions about "when is it okay to share feedback" keep coming up (most recently at netconf) and the answer is "pretty much always". Extend the section of 7.AdvancedTopics.rst which deals with reviews a little bit to add stuff we had been recommending locally. Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/process/maintainer-netdev.rst')
-rw-r--r--Documentation/process/maintainer-netdev.rst15
1 files changed, 15 insertions, 0 deletions
diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
index 09dcf6377c27..7feacc20835e 100644
--- a/Documentation/process/maintainer-netdev.rst
+++ b/Documentation/process/maintainer-netdev.rst
@@ -441,6 +441,21 @@ in a way which would break what would normally be considered uAPI.
new ``netdevsim`` features must be accompanied by selftests under
``tools/testing/selftests/``.
+Reviewer guidance
+-----------------
+
+Reviewing other people's patches on the list is highly encouraged,
+regardless of the level of expertise. For general guidance and
+helpful tips please see :ref:`development_advancedtopics_reviews`.
+
+It's safe to assume that netdev maintainers know the community and the level
+of expertise of the reviewers. The reviewers should not be concerned about
+their comments impeding or derailing the patch flow.
+
+Less experienced reviewers are highly encouraged to do more in-depth
+review of submissions and not focus exclusively on trivial or subjective
+matters like code formatting, tags etc.
+
Testimonials / feedback
-----------------------