diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2024-02-13 22:05:20 +0100 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2024-02-15 22:07:41 +0100 |
| commit | 4a5f72a4a39f5d5dcf9b9dc1acc57ecbbb8d4caa (patch) | |
| tree | a0d73d7cbc0b457eaec6dd9abf17c1f128ce0abd /arch/x86/kernel/apic/apic.c | |
| parent | x86/apic: Remove the pointless writeback of boot_cpu_physical_apicid (diff) | |
| download | linux-4a5f72a4a39f5d5dcf9b9dc1acc57ecbbb8d4caa.tar.xz linux-4a5f72a4a39f5d5dcf9b9dc1acc57ecbbb8d4caa.zip | |
x86/apic: Remove yet another dubious callback
Paranoia is not wrong, but having an APIC callback which is in most
implementations a complete NOOP and in one actually looking whether the
APICID of an upcoming CPU has been registered. The same APICID which was
used to bring the CPU out of wait for startup.
That's paranoia for the paranoia sake. Remove the voodoo.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Michael Kelley <mhklinux@outlook.com>
Tested-by: Sohil Mehta <sohil.mehta@intel.com>
Link: https://lore.kernel.org/r/20240212154640.116510935@linutronix.de
Diffstat (limited to 'arch/x86/kernel/apic/apic.c')
| -rw-r--r-- | arch/x86/kernel/apic/apic.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index e3cebd45526b..68767a9dd3d1 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1538,9 +1538,6 @@ static void setup_local_APIC(void) apic_write(APIC_ESR, 0); } #endif - /* Validate that the APIC is registered if required */ - BUG_ON(apic->apic_id_registered && !apic->apic_id_registered()); - /* * Intel recommends to set DFR, LDR and TPR before enabling * an APIC. See e.g. "AP-388 82489DX User's Manual" (Intel |