diff options
| author | Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> | 2024-11-13 14:41:18 +0100 |
|---|---|---|
| committer | Vineet Gupta <vgupta@kernel.org> | 2024-12-10 19:12:56 +0100 |
| commit | 7dd9eb6ba88964b091b89855ce7d2a12405013af (patch) | |
| tree | a16ba8c4becc929d71a7611f0b4f5b2de20330db /arch | |
| parent | ARC: dts: Replace deprecated snps,nr-gpios property for snps,dw-apb-gpio-port... (diff) | |
| download | linux-7dd9eb6ba88964b091b89855ce7d2a12405013af.tar.xz linux-7dd9eb6ba88964b091b89855ce7d2a12405013af.zip | |
ARC: bpf: Correct conditional check in 'check_jmp_32'
The original code checks 'if (ARC_CC_AL)', which is always true since
ARC_CC_AL is a constant. This makes the check redundant and likely
obscures the intention of verifying whether the jump is conditional.
Updates the code to check cond == ARC_CC_AL instead, reflecting the intent
to differentiate conditional from unconditional jumps.
Suggested-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Acked-by: Shahab Vahedi <list+bpf@vahedi.org>
Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Signed-off-by: Vineet Gupta <vgupta@kernel.org>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/arc/net/bpf_jit_arcv2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arc/net/bpf_jit_arcv2.c b/arch/arc/net/bpf_jit_arcv2.c index 4458e409ca0a..6d989b6d88c6 100644 --- a/arch/arc/net/bpf_jit_arcv2.c +++ b/arch/arc/net/bpf_jit_arcv2.c @@ -2916,7 +2916,7 @@ bool check_jmp_32(u32 curr_off, u32 targ_off, u8 cond) addendum = (cond == ARC_CC_AL) ? 0 : INSN_len_normal; disp = get_displacement(curr_off + addendum, targ_off); - if (ARC_CC_AL) + if (cond == ARC_CC_AL) return is_valid_far_disp(disp); else return is_valid_near_disp(disp); |