diff options
| author | Jens Axboe <axboe@kernel.dk> | 2024-10-07 00:52:33 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2024-10-22 16:15:17 +0200 |
| commit | 746fc7e9d459ae3731104d719e22b13829f71e55 (patch) | |
| tree | 4f60a7792fa97a6b5ad0cb7c0f78d1f3c947fadd /block/blk-mq.c | |
| parent | block: set issue time stamp based on queue state (diff) | |
| download | linux-746fc7e9d459ae3731104d719e22b13829f71e55.tar.xz linux-746fc7e9d459ae3731104d719e22b13829f71e55.zip | |
block: move issue side time stamping to blk_account_io_start()
It's known needed at that point, and it's cleaner to just assign it
there rather than rely on it being reliably set before hitting the
IO accounting. Hence, move it out of blk_mq_rq_time_init(), which is
now only doing the allocation side timing.
While at it, get rid of the '0' time passing to blk_mq_rq_time_init(),
just pass in blk_time_get_ns() for the two cases where 0 is being
explicitly passed in. The rest pass in the previously cached allocation
time.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-mq.c')
| -rw-r--r-- | block/blk-mq.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index 9a3a9a370618..f4f78c03f735 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -331,14 +331,9 @@ EXPORT_SYMBOL(blk_rq_init); /* Set start and alloc time when the allocated request is actually used */ static inline void blk_mq_rq_time_init(struct request *rq, u64 alloc_time_ns) { - if (blk_queue_io_stat(rq->q)) - rq->start_time_ns = blk_time_get_ns(); - else - rq->start_time_ns = 0; - #ifdef CONFIG_BLK_RQ_ALLOC_TIME if (blk_queue_rq_alloc_time(rq->q)) - rq->alloc_time_ns = alloc_time_ns ?: rq->start_time_ns; + rq->alloc_time_ns = alloc_time_ns; else rq->alloc_time_ns = 0; #endif @@ -566,7 +561,7 @@ static struct request *blk_mq_alloc_cached_request(struct request_queue *q, return NULL; plug->cached_rq = rq_list_next(rq); - blk_mq_rq_time_init(rq, 0); + blk_mq_rq_time_init(rq, blk_time_get_ns()); } rq->cmd_flags = opf; @@ -1003,6 +998,7 @@ static inline void blk_account_io_start(struct request *req) return; req->rq_flags |= RQF_IO_STAT; + req->start_time_ns = blk_time_get_ns(); /* * All non-passthrough requests are created from a bio with one @@ -2909,7 +2905,7 @@ static void blk_mq_use_cached_rq(struct request *rq, struct blk_plug *plug, plug->cached_rq = rq_list_next(rq); rq_qos_throttle(rq->q, bio); - blk_mq_rq_time_init(rq, 0); + blk_mq_rq_time_init(rq, blk_time_get_ns()); rq->cmd_flags = bio->bi_opf; INIT_LIST_HEAD(&rq->queuelist); } |