diff options
| author | Damien Le Moal <dlemoal@kernel.org> | 2024-07-30 07:38:07 +0200 |
|---|---|---|
| committer | Damien Le Moal <dlemoal@kernel.org> | 2024-08-02 02:18:42 +0200 |
| commit | b40824500eaa77668026b6d1ade6924901a680f9 (patch) | |
| tree | c40b717961c2adee9651e6bb289c0e0fd4b365a3 /drivers/ata/libata-sff.c | |
| parent | ata: pata_hpt37x: Rename hpt_dma_blacklisted() (diff) | |
| download | linux-b40824500eaa77668026b6d1ade6924901a680f9.tar.xz linux-b40824500eaa77668026b6d1ade6924901a680f9.zip | |
ata: libata: Remove ata_noop_qc_prep()
The function ata_noop_qc_prep(), as its name implies, does nothing and
simply returns AC_ERR_OK. For drivers that do not need any special
preparations of queued commands, we can avoid having to define struct
ata_port qc_prep operation by simply testing if that operation is
defined or not in ata_qc_issue(). Make this change and remove
ata_noop_qc_prep().
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Diffstat (limited to 'drivers/ata/libata-sff.c')
| -rw-r--r-- | drivers/ata/libata-sff.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 06868ec5b1fd..67f277e1c3bf 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -26,7 +26,6 @@ static struct workqueue_struct *ata_sff_wq; const struct ata_port_operations ata_sff_port_ops = { .inherits = &ata_base_port_ops, - .qc_prep = ata_noop_qc_prep, .qc_issue = ata_sff_qc_issue, .qc_fill_rtf = ata_sff_qc_fill_rtf, |