diff options
author | Pin-yen Lin <treapking@chromium.org> | 2024-03-12 12:51:55 +0100 |
---|---|---|
committer | Stephen Boyd <sboyd@kernel.org> | 2024-04-11 05:50:06 +0200 |
commit | 2f7b1d8b5505efb0057cd1ab85fca206063ea4c3 (patch) | |
tree | 304f7f330a486848d6e94f561efb57f65fc3deae /drivers/clk/mediatek/clk-mt2701-hif.c | |
parent | Merge branch 'clk-rpm' into clk-fixes (diff) | |
download | linux-2f7b1d8b5505efb0057cd1ab85fca206063ea4c3.tar.xz linux-2f7b1d8b5505efb0057cd1ab85fca206063ea4c3.zip |
clk: mediatek: Do a runtime PM get on controllers during probe
mt8183-mfgcfg has a mutual dependency with genpd during the probing
stage, which leads to a deadlock in the following call stack:
CPU0: genpd_lock --> clk_prepare_lock
genpd_power_off_work_fn()
genpd_lock()
generic_pm_domain::power_off()
clk_unprepare()
clk_prepare_lock()
CPU1: clk_prepare_lock --> genpd_lock
clk_register()
__clk_core_init()
clk_prepare_lock()
clk_pm_runtime_get()
genpd_lock()
Do a runtime PM get at the probe function to make sure clk_register()
won't acquire the genpd lock. Instead of only modifying mt8183-mfgcfg,
do this on all mediatek clock controller probings because we don't
believe this would cause any regression.
Verified on MT8183 and MT8192 Chromebooks.
Fixes: acddfc2c261b ("clk: mediatek: Add MT8183 clock support")
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Link: https://lore.kernel.org/r/20240312115249.3341654-1-treapking@chromium.org
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/mediatek/clk-mt2701-hif.c')
0 files changed, 0 insertions, 0 deletions