diff options
author | Jon Medhurst \(Tixy\) <tixy@linaro.org> | 2015-10-21 11:55:33 +0200 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-11-02 01:58:27 +0100 |
commit | 14f1ba3af6209f0394192ef07fe2bd9bccdc755f (patch) | |
tree | 0441ad96036b06ea942e890b5d08a86947ba7f4a /drivers/cpufreq/intel_pstate.c | |
parent | cpufreq: postfix policy directory with the first CPU in related_cpus (diff) | |
download | linux-14f1ba3af6209f0394192ef07fe2bd9bccdc755f.tar.xz linux-14f1ba3af6209f0394192ef07fe2bd9bccdc755f.zip |
cpufreq: arm_big_little: fix frequency check when bL switcher is active
The check for correct frequency being set in bL_cpufreq_set_rate is
broken when the big.LITTLE switcher is active, for two reasons.
1. The 'new_rate' variable gets overwritten before the test by the
code calculating the frequency of the old cluster.
2. The frequency returned by bL_cpufreq_get_rate will be the virtual
frequency, not the actual one the intended version of new_rate contains.
This means the function always returns an error causing an endless
stream of: "cpufreq: __target_index: Failed to change cpu frequency: -5"
As the intent is to check for errors that clk_set_rate doesn't report
lets move the check to immediately after that and directly use
clk_get_rate, rather than the arm_big_little helpers which only confuse
matters. Also, update the comment to be hopefully clearer about the
purpose of the code.
Fixes: 0a95e630b49a (cpufreq: arm_big_little: check if the frequency is set correctly)
Signed-off-by: Jon Medhurst <tixy@linaro.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/intel_pstate.c')
0 files changed, 0 insertions, 0 deletions