diff options
author | Tudor Ambarus <tudor.ambarus@microchip.com> | 2019-12-13 10:54:42 +0100 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-12-20 07:58:34 +0100 |
commit | 0e69378940eafe386464679a84856d1b63e1bac2 (patch) | |
tree | f2e10f30595cc313c2103cbb1c2c131ae4a1e8d5 /drivers/crypto/atmel-tdes.c | |
parent | crypto: amlogic - add unspecified HAS_IOMEM dependency (diff) | |
download | linux-0e69378940eafe386464679a84856d1b63e1bac2.tar.xz linux-0e69378940eafe386464679a84856d1b63e1bac2.zip |
crypto: atmel-{aes,sha} - Fix incorrect use of dmaengine_terminate_all()
device_terminate_all() is used to abort all the pending and
ongoing transfers on the channel, it should be used just in the
error path.
Also, dmaengine_terminate_all() is deprecated and one should use
dmaengine_terminate_async() or dmaengine_terminate_sync(). The method
is not used in atomic context, use dmaengine_terminate_sync().
A secondary aspect of this patch is that it luckily avoids a deadlock
between atmel_aes and at_hdmac.c. While in tasklet with the lock held,
the dma controller invokes the client callback (dmaengine_terminate_all),
which tries to get the same lock. The at_hdmac fix would be to drop the
lock before invoking the client callback, a fix on at_hdmac will follow.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/atmel-tdes.c')
0 files changed, 0 insertions, 0 deletions