diff options
| author | Javier Carrasco <javier.carrasco.cruz@gmail.com> | 2024-10-11 22:57:59 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-12-24 11:15:01 +0100 |
| commit | 362f1bf98a3ecb5a2a4fcbdaa9718c8403beceb2 (patch) | |
| tree | 128d4e46d7ea890310a3e4a71729c9925bf9f47c /drivers/dma | |
| parent | dmaengine: fsl-edma: implement the cleanup path of fsl_edma3_attach_pd() (diff) | |
| download | linux-362f1bf98a3ecb5a2a4fcbdaa9718c8403beceb2.tar.xz linux-362f1bf98a3ecb5a2a4fcbdaa9718c8403beceb2.zip | |
dmaengine: mv_xor: fix child node refcount handling in early exit
The for_each_child_of_node() loop requires explicit calls to
of_node_put() to decrement the child's refcount upon early exits (break,
goto, return).
Add the missing calls in the two early exits before the goto
instructions.
Cc: stable@vger.kernel.org
Fixes: f7d12ef53ddf ("dma: mv_xor: add Device Tree binding")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20241011-dma_mv_xor_of_node_put-v1-1-3c2de819f463@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/mv_xor.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 43efce77bb57..40b76b40bc30 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1388,6 +1388,7 @@ static int mv_xor_probe(struct platform_device *pdev) irq = irq_of_parse_and_map(np, 0); if (!irq) { ret = -ENODEV; + of_node_put(np); goto err_channel_add; } @@ -1396,6 +1397,7 @@ static int mv_xor_probe(struct platform_device *pdev) if (IS_ERR(chan)) { ret = PTR_ERR(chan); irq_dispose_mapping(irq); + of_node_put(np); goto err_channel_add; } |