diff options
| author | Christian König <ckoenig.leichtzumerken@gmail.com> | 2021-07-28 15:05:50 +0200 |
|---|---|---|
| committer | Christian König <christian.koenig@amd.com> | 2021-08-23 13:43:35 +0200 |
| commit | 61a8736fd82254cf9757b2a8590c84f75aa1f12d (patch) | |
| tree | aaa801638135d30650b61707873dc08cf3a661f6 /drivers/gpu/drm/nouveau/nouveau_sgdma.c | |
| parent | drm/amdgpu: unbind in amdgpu_ttm_tt_unpopulate (diff) | |
| download | linux-61a8736fd82254cf9757b2a8590c84f75aa1f12d.tar.xz linux-61a8736fd82254cf9757b2a8590c84f75aa1f12d.zip | |
drm/nouveau: unbind in nouveau_ttm_tt_unpopulate
Doing this in nouveau_ttm_tt_destroy()/nouveau_sgdma_destroy() is to late.
It turned out that this is not a good idea at all because it leaves pointers
to freed up system memory pages in the GART tables of the drivers.
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210728130552.2074-3-christian.koenig@amd.com
Diffstat (limited to 'drivers/gpu/drm/nouveau/nouveau_sgdma.c')
| -rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_sgdma.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c index 256ec5b35473..bde92a9dae7a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c @@ -21,7 +21,6 @@ nouveau_sgdma_destroy(struct ttm_device *bdev, struct ttm_tt *ttm) struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; if (ttm) { - nouveau_sgdma_unbind(bdev, ttm); ttm_tt_destroy_common(bdev, ttm); ttm_tt_fini(&nvbe->ttm); kfree(nvbe); |