summaryrefslogtreecommitdiffstats
path: root/drivers/iio/dac/mcp4725.c
diff options
context:
space:
mode:
authorMatti Vaittinen <mazziesaccount@gmail.com>2023-05-12 09:53:41 +0200
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2023-05-13 20:45:08 +0200
commit56cd3d1c5c5b073a1a444eafdcf97d4d866d351a (patch)
treeb25091be83388f3a3f70b25e3ed5b6c0c88a0bc7 /drivers/iio/dac/mcp4725.c
parentiio: bu27034: Ensure reset is written (diff)
downloadlinux-56cd3d1c5c5b073a1a444eafdcf97d4d866d351a.tar.xz
linux-56cd3d1c5c5b073a1a444eafdcf97d4d866d351a.zip
iio: accel: kx022a fix irq getting
The fwnode_irq_get_byname() was returning 0 at device-tree mapping error. If this occurred, the KX022A driver did abort the probe but errorneously directly returned the return value from fwnode_irq_get_byname() from probe. In case of a device-tree mapping error this indicated success. The fwnode_irq_get_byname() has since been fixed to not return zero on error so the check for fwnode_irq_get_byname() can be relaxed to only treat negative values as errors. This will also do decent fix even when backported to branches where fwnode_irq_get_byname() can still return zero on error because KX022A probe should later fail at IRQ requesting and a prober error handling should follow. Relax the return value check for fwnode_irq_get_byname() to only treat negative values as errors. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Closes: https://lore.kernel.org/r/202305110245.MFxC9bUj-lkp@intel.com/ Link: https://lore.kernel.org/r/202305110245.MFxC9bUj-lkp@intel.com/ Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> Fixes: 7c1d1677b322 ("iio: accel: Support Kionix/ROHM KX022A accelerometer") Link: https://lore.kernel.org/r/b45b4b638db109c6078d243252df3a7b0485f7d5.1683875389.git.mazziesaccount@gmail.com Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/dac/mcp4725.c')
0 files changed, 0 insertions, 0 deletions