diff options
author | Ivan Vecera <cera@cera.cz> | 2017-05-19 19:30:43 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-05-22 20:40:22 +0200 |
commit | bd080488a6cfd37135becedfdc87643b139c2345 (patch) | |
tree | b3ec5d73cf9895423e5e75cd7985821d0c0a65be /drivers/mfd/as3711.c | |
parent | net/wan/fsl_ucc_hdlc: fix muram allocation error (diff) | |
download | linux-bd080488a6cfd37135becedfdc87643b139c2345.tar.xz linux-bd080488a6cfd37135becedfdc87643b139c2345.zip |
bridge: fix hello and hold timers starting/stopping
Current bridge code incorrectly handles starting/stopping of hello and
hold timers during STP enable/disable.
1. Timers are stopped in br_stp_start() during NO_STP->USER_STP
transition. The timers are already stopped in NO_STP state so
this is confusing no-op.
2. During USER_STP->NO_STP transition the timers are started. This
does not make sense and is confusion because the timer should not be
active in NO_STP state.
Cc: davem@davemloft.net
Cc: sashok@cumulusnetworks.com
Cc: stephen@networkplumber.org
Cc: bridge@lists.linux-foundation.org
Cc: lucien.xin@gmail.com
Cc: nikolay@cumulusnetworks.com
Signed-off-by: Ivan Vecera <cera@cera.cz>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/mfd/as3711.c')
0 files changed, 0 insertions, 0 deletions