diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-09 12:47:36 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-11-09 14:58:46 +0100 |
| commit | 1c360cc1cc883fbdf0a258b4df376571fbeac5ee (patch) | |
| tree | 8a56e2969d64c6e9a0f2e0ff768a2c6dd2ad37d4 /drivers/net/ethernet/google | |
| parent | hamradio: defer 6pack kfree after unregister_netdev (diff) | |
| download | linux-1c360cc1cc883fbdf0a258b4df376571fbeac5ee.tar.xz linux-1c360cc1cc883fbdf0a258b4df376571fbeac5ee.zip | |
gve: Fix off by one in gve_tx_timeout()
The priv->ntfy_blocks[] has "priv->num_ntfy_blks" elements so this >
needs to be >= to prevent an off by one bug. The priv->ntfy_blocks[]
array is allocated in gve_alloc_notify_blocks().
Fixes: 87a7f321bb6a ("gve: Recover from queue stall due to missed IRQ")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/google')
| -rw-r--r-- | drivers/net/ethernet/google/gve/gve_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index 6b02ef432eda..59b66f679e46 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -1137,7 +1137,7 @@ static void gve_tx_timeout(struct net_device *dev, unsigned int txqueue) goto reset; ntfy_idx = gve_tx_idx_to_ntfy(priv, txqueue); - if (ntfy_idx > priv->num_ntfy_blks) + if (ntfy_idx >= priv->num_ntfy_blks) goto reset; block = &priv->ntfy_blocks[ntfy_idx]; |