diff options
| author | Huazhong Tan <tanhuazhong@huawei.com> | 2019-01-30 21:55:49 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-30 23:50:03 +0100 |
| commit | 9fc55413270fffe1b5ebdea03489d763c62c0305 (patch) | |
| tree | 63922ea0269f35ad1dbb860011682cb5a6cddd08 /drivers/net/ethernet/hisilicon | |
| parent | net: hns3: fix for rss result nonuniform (diff) | |
| download | linux-9fc55413270fffe1b5ebdea03489d763c62c0305.tar.xz linux-9fc55413270fffe1b5ebdea03489d763c62c0305.zip | |
net: hns3: fix improper error handling in the hclge_init_ae_dev()
While hclge_init_umv_space() failed in the hclge_init_ae_dev(),
we should undo all the operation which has been done successfully,
the last success operation maybe hclge_mac_mdio_config(), so if
hclge_init_umv_space() failed, we also need to undo it.
Fixes: 288475b2ad01 ("{topost} net: hns3: refine umv space allocation")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index 42f0f8824b47..b531eac12fea 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -7383,7 +7383,7 @@ static int hclge_init_ae_dev(struct hnae3_ae_dev *ae_dev) ret = hclge_init_umv_space(hdev); if (ret) { dev_err(&pdev->dev, "umv space init error, ret=%d.\n", ret); - goto err_msi_irq_uninit; + goto err_mdiobus_unreg; } ret = hclge_mac_init(hdev); |