diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2021-05-25 12:46:17 +0200 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2021-06-15 16:03:21 +0200 |
| commit | e9ca70c735ce66fc6a0e02c8b6958434f74ef8de (patch) | |
| tree | 813869e5e4d31a6fb2e74a4767f7bd930c0763e0 /drivers/net/wireless/ath/ath10k/mac.c | |
| parent | ath11k: Fix an error handling path in ath11k_core_fetch_board_data_api_n() (diff) | |
| download | linux-e9ca70c735ce66fc6a0e02c8b6958434f74ef8de.tar.xz linux-e9ca70c735ce66fc6a0e02c8b6958434f74ef8de.zip | |
ath10k: Fix an error code in ath10k_add_interface()
When the code execute this if statement, the value of ret is 0.
However, we can see from the ath10k_warn() log that the value of
ret should be -EINVAL.
Clean up smatch warning:
drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn:
missing error code 'ret'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com
Diffstat (limited to 'drivers/net/wireless/ath/ath10k/mac.c')
| -rw-r--r-- | drivers/net/wireless/ath/ath10k/mac.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 5ce4f8d038b9..c272b290fa73 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -5592,6 +5592,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, if (arvif->nohwcrypt && !test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) { + ret = -EINVAL; ath10k_warn(ar, "cryptmode module param needed for sw crypto\n"); goto err; } |