summaryrefslogtreecommitdiffstats
path: root/drivers/platform
diff options
context:
space:
mode:
authorJens Axboe <axboe@kernel.dk>2025-01-03 17:29:09 +0100
committerJens Axboe <axboe@kernel.dk>2025-01-03 17:38:37 +0100
commited123c948d06688d10f3b10a7bce1d6fbfd1ed07 (patch)
treef301561101f81b7334cfe4f201d72128fb7f8fc3 /drivers/platform
parentio_uring/net: always initialize kmsg->msg.msg_inq upfront (diff)
downloadlinux-ed123c948d06688d10f3b10a7bce1d6fbfd1ed07.tar.xz
linux-ed123c948d06688d10f3b10a7bce1d6fbfd1ed07.zip
io_uring/kbuf: use pre-committed buffer address for non-pollable file
For non-pollable files, buffer ring consumption will commit upfront. This is fine, but io_ring_buffer_select() will return the address of the buffer after having committed it. For incrementally consumed buffers, this is incorrect as it will modify the buffer address. Store the pre-committed value and return that. If that isn't done, then the initial part of the buffer is not used and the application will correctly assume the content arrived at the start of the userspace buffer, but the kernel will have put it later in the buffer. Or it can cause a spurious -EFAULT returned in the CQE, depending on the buffer size. As bounds are suitably checked for doing the actual IO, no adverse side effects are possible - it's just a data misplacement within the existing buffer. Reported-by: Gwendal Fernet <gwendalfernet@gmail.com> Cc: stable@vger.kernel.org Fixes: ae98dbf43d75 ("io_uring/kbuf: add support for incremental buffer consumption") Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/platform')
0 files changed, 0 insertions, 0 deletions