diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2015-02-25 10:39:36 +0100 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2015-02-26 03:09:51 +0100 |
commit | 9d239d353c319f9ff884c287ce47feb7cdf60ddc (patch) | |
tree | a30fb77d6c28bf18e6433df1db4fc4bf27d04295 /drivers/spi/spi-dw-mid.c | |
parent | spi: dw-pci: correct number of chip selects (diff) | |
download | linux-9d239d353c319f9ff884c287ce47feb7cdf60ddc.tar.xz linux-9d239d353c319f9ff884c287ce47feb7cdf60ddc.zip |
spi: dw: revisit FIFO size detection again
The commit d297933cc7fc (spi: dw: Fix detecting FIFO depth) tries to fix the
logic of the FIFO detection based on the description on the comments. However,
there is a slight difference between numbers in TX Level and TX FIFO size.
So, by specification the FIFO size would be in a range 2-256 bytes. From TX
Level prospective it means we can set threshold in the range 0-(FIFO size - 1)
bytes. Hence there are currently two issues:
a) FIFO size 2 bytes is actually skipped since TX Level is 1 bit and could be
either 0 or 1 byte;
b) FIFO size is incorrectly decreased by 1 which already done by meaning of
TX Level register.
This patch fixes it eventually right.
Fixes: d297933cc7fc (spi: dw: Fix detecting FIFO depth)
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/spi/spi-dw-mid.c')
0 files changed, 0 insertions, 0 deletions