diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-10 08:39:35 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-11-12 19:18:01 +0100 |
| commit | 6532582c353f4c83e3ccdd7255020ab852b90b0b (patch) | |
| tree | de1c395e91f0c6d03ccf06eb7de5da18fde946e7 /drivers/spi/spi-rb4xx.c | |
| parent | spi: lpspi: Silence error message upon deferred probe (diff) | |
| download | linux-6532582c353f4c83e3ccdd7255020ab852b90b0b.tar.xz linux-6532582c353f4c83e3ccdd7255020ab852b90b0b.zip | |
spi: spi-geni-qcom: fix error handling in spi_geni_grab_gpi_chan()
This code has several issues:
1) It passes IS_ERR() to dev_err_probe() instead of PTR_ERR().
2) It always prints an error message, even when it succeeds.
3) The "if (ret < 0) {" conditions are never true.
4) If requesting "mas->tx" fails then it sets "mas->rx" to NULL but the
intention was to set "mas->tx" to NULL.
Fixes: b59c122484ec ("spi: spi-geni-qcom: Add support for GPI dma")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20211110073935.GA5176@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-rb4xx.c')
0 files changed, 0 insertions, 0 deletions