summaryrefslogtreecommitdiffstats
path: root/drivers/usb/cdns3/core.h
diff options
context:
space:
mode:
authorPeter Chen <peter.chen@nxp.com>2020-03-31 10:10:03 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-04-16 15:31:35 +0200
commit85820de1b6109ffcfc4c5e9bb27e31f130725223 (patch)
treea623a58389025c8f7b0c11f7e1b20ffe07357071 /drivers/usb/cdns3/core.h
parentusb: cdns3: core: get role switch node from firmware (diff)
downloadlinux-85820de1b6109ffcfc4c5e9bb27e31f130725223.tar.xz
linux-85820de1b6109ffcfc4c5e9bb27e31f130725223.zip
usb: cdns3: delete role_override
In short, we have three kinds of role switches: - Based on SoC: ID and VBUS - Based on external connnctor, eg, Type-C or GPIO Connector - Based on user choices through sysfs Since HW handling and usb-role-switch handling are at different places, we do not need role_override any more, and this flag could not judge external connector case well. With role_override deleted, We use cdns3_hw_role_switch for the 1st use case, and usb-role-switch for the 2nd and 3rd cases. Signed-off-by: Peter Chen <peter.chen@nxp.com> Reviewed-by: Roger Quadros <rogerq@ti.com> Link: https://lore.kernel.org/r/20200331081005.32752-2-peter.chen@nxp.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/cdns3/core.h')
-rw-r--r--drivers/usb/cdns3/core.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h
index 969eb94de204..1ad1f1fe61e9 100644
--- a/drivers/usb/cdns3/core.h
+++ b/drivers/usb/cdns3/core.h
@@ -62,7 +62,6 @@ struct cdns3_role_driver {
* This field based on firmware setting, kernel configuration
* and hardware configuration.
* @role_sw: pointer to role switch object.
- * @role_override: set 1 if role rely on SW.
*/
struct cdns3 {
struct device *dev;
@@ -90,7 +89,6 @@ struct cdns3 {
struct mutex mutex;
enum usb_dr_mode dr_mode;
struct usb_role_switch *role_sw;
- int role_override;
};
int cdns3_hw_role_switch(struct cdns3 *cdns);