diff options
author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-04-24 18:11:21 +0200 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> | 2018-04-24 18:11:21 +0200 |
commit | 12f3ac2fb16130e4afcfde986fb97f61cb54eead (patch) | |
tree | db106f43cf3d6f26be808c93913e02e0108b615a /drivers/video/fbdev/aty | |
parent | Merge tag 'v4.17-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/torval... (diff) | |
download | linux-12f3ac2fb16130e4afcfde986fb97f61cb54eead.tar.xz linux-12f3ac2fb16130e4afcfde986fb97f61cb54eead.zip |
video: fbdev: savage: Replace mdelay with usleep_range in savage_init_hw
savage_init_hw() is never called in atomic context.
The call chains ending up at savage_init_hw() are:
[1] savage_init_hw() <- savagefb_probe()
[2] savage_init_hw() <- savagefb_resume()
savagefb_probe() is only set as ".probe" in struct pci_driver.
savagefb_resume) is only set as ".resume" in struct pci_driver.
These functions are not called in atomic context.
Despite never getting called from atomic context, savage_init_hw()
calls mdelay() to busily wait.
This is not necessary and can be replaced with usleep_range to
avoid busy waiting.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'drivers/video/fbdev/aty')
0 files changed, 0 insertions, 0 deletions