summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorZheng Qixing <zhengqixing@huawei.com>2024-08-22 05:30:50 +0200
committerDamien Le Moal <dlemoal@kernel.org>2024-08-26 23:54:36 +0200
commit284b75a3d83c7631586d98f6dede1d90f128f0db (patch)
tree2ebf04915b6976c418b592e81f9796d8b9967578 /drivers
parentata: pata_macio: Use WARN instead of BUG (diff)
downloadlinux-284b75a3d83c7631586d98f6dede1d90f128f0db.tar.xz
linux-284b75a3d83c7631586d98f6dede1d90f128f0db.zip
ata: libata: Fix memory leak for error path in ata_host_alloc()
In ata_host_alloc(), if devres_alloc() fails to allocate the device host resource data pointer, the already allocated ata_host structure is not freed before returning from the function. This results in a potential memory leak. Call kfree(host) before jumping to the error handling path to ensure that the ata_host structure is properly freed if devres_alloc() fails. Fixes: 2623c7a5f279 ("libata: add refcounting to ata_host") Cc: stable@vger.kernel.org Signed-off-by: Zheng Qixing <zhengqixing@huawei.com> Reviewed-by: Yu Kuai <yukuai3@huawei.com> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/ata/libata-core.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index c7752dc80028..30932552437a 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5593,8 +5593,10 @@ struct ata_host *ata_host_alloc(struct device *dev, int n_ports)
}
dr = devres_alloc(ata_devres_release, 0, GFP_KERNEL);
- if (!dr)
+ if (!dr) {
+ kfree(host);
goto err_out;
+ }
devres_add(dev, dr);
dev_set_drvdata(dev, host);