summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2024-06-04 17:02:15 +0200
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>2024-06-11 15:58:52 +0200
commit2ccfe94bc3ac980d2d1df9f7a0b2c6d2137abe55 (patch)
tree5983b61652e4a6ca8a1c8184b554bdc59f8d0884 /drivers
parentauxdisplay: Use sizeof(*pointer) instead of sizeof(type) (diff)
downloadlinux-2ccfe94bc3ac980d2d1df9f7a0b2c6d2137abe55.tar.xz
linux-2ccfe94bc3ac980d2d1df9f7a0b2c6d2137abe55.zip
auxdisplay: ht16k33: Drop reference after LED registration
The reference count is bumped by device_get_named_child_node() and never dropped. Since LED APIs do not require it to be bumped by the user, drop the reference after LED registration. [andy: rewritten the commit message and amended the change] Fixes: c223d9c636ed ("auxdisplay: ht16k33: Add LED support") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/auxdisplay/ht16k33.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index ce987944662c..8a7034b41d50 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -483,6 +483,7 @@ static int ht16k33_led_probe(struct device *dev, struct led_classdev *led,
led->max_brightness = MAX_BRIGHTNESS;
err = devm_led_classdev_register_ext(dev, led, &init_data);
+ fwnode_handle_put(init_data.fwnode);
if (err)
dev_err(dev, "Failed to register LED\n");