summaryrefslogtreecommitdiffstats
path: root/fs/bcachefs/journal_reclaim.c
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@gmail.com>2019-03-01 21:51:57 +0100
committerKent Overstreet <kent.overstreet@linux.dev>2023-10-22 23:08:16 +0200
commitdc9aa17841e83b6d6ca5abe295545ca0764e1580 (patch)
treeb2d8669644893896b3d1a8a51563b9ae4ee4f409 /fs/bcachefs/journal_reclaim.c
parentbcachefs: improved flush_held_btree_writes() (diff)
downloadlinux-dc9aa17841e83b6d6ca5abe295545ca0764e1580.tar.xz
linux-dc9aa17841e83b6d6ca5abe295545ca0764e1580.zip
bcachefs: Drop a faulty assertion
the assertion was meant to check that bch2_journal_reclaim_fast() was always being called, but since the atomic dec can happen outside of j->lock the assertion itself can race Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/journal_reclaim.c')
-rw-r--r--fs/bcachefs/journal_reclaim.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/bcachefs/journal_reclaim.c b/fs/bcachefs/journal_reclaim.c
index 3b5b646859cb..431afeab42b0 100644
--- a/fs/bcachefs/journal_reclaim.c
+++ b/fs/bcachefs/journal_reclaim.c
@@ -333,8 +333,6 @@ journal_get_next_pin(struct journal *j, u64 max_seq, u64 *seq)
spin_lock(&j->lock);
- BUG_ON(!atomic_read(&fifo_peek_front(&j->pin).count));
-
fifo_for_each_entry_ptr(pin_list, &j->pin, *seq)
if (*seq > max_seq ||
(ret = list_first_entry_or_null(&pin_list->list,