diff options
| author | Filipe Manana <fdmanana@suse.com> | 2023-07-26 17:56:57 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-08-21 14:52:17 +0200 |
| commit | 4490e803e1fe9fab8db5025e44e23b55df54078b (patch) | |
| tree | 6d2cfc7c558c3f531ca37dd5a36c886ab7dfe5e4 /fs/btrfs/transaction.c | |
| parent | btrfs: refactor main loop in memmove_extent_buffer() (diff) | |
| download | linux-4490e803e1fe9fab8db5025e44e23b55df54078b.tar.xz linux-4490e803e1fe9fab8db5025e44e23b55df54078b.zip | |
btrfs: don't start transaction when joining with TRANS_JOIN_NOSTART
When joining a transaction with TRANS_JOIN_NOSTART, if we don't find a
running transaction we end up creating one. This goes against the purpose
of TRANS_JOIN_NOSTART which is to join a running transaction if its state
is at or below the state TRANS_STATE_COMMIT_START, otherwise return an
-ENOENT error and don't start a new transaction. So fix this to not create
a new transaction if there's no running transaction at or below that
state.
CC: stable@vger.kernel.org # 4.14+
Fixes: a6d155d2e363 ("Btrfs: fix deadlock between fiemap and transaction commits")
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/transaction.c')
| -rw-r--r-- | fs/btrfs/transaction.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 815f61d6b506..6a2a12593183 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -292,10 +292,11 @@ loop: spin_unlock(&fs_info->trans_lock); /* - * If we are ATTACH, we just want to catch the current transaction, - * and commit it. If there is no transaction, just return ENOENT. + * If we are ATTACH or TRANS_JOIN_NOSTART, we just want to catch the + * current transaction, and commit it. If there is no transaction, just + * return ENOENT. */ - if (type == TRANS_ATTACH) + if (type == TRANS_ATTACH || type == TRANS_JOIN_NOSTART) return -ENOENT; /* |