diff options
| author | Filipe Manana <fdmanana@suse.com> | 2024-11-15 16:46:13 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-11-29 16:46:47 +0100 |
| commit | ed67f2a913a4f0fc505db29805c41dd07d3cb356 (patch) | |
| tree | 7a083de52f20427b6d28a97461ff7731f58978e0 /fs/btrfs | |
| parent | btrfs: sysfs: advertise experimental features only if CONFIG_BTRFS_EXPERIMENT... (diff) | |
| download | linux-ed67f2a913a4f0fc505db29805c41dd07d3cb356.tar.xz linux-ed67f2a913a4f0fc505db29805c41dd07d3cb356.zip | |
btrfs: don't loop for nowait writes when checking for cross references
When checking for delayed refs when verifying if there are cross
references for a data extent, we stop if the path has nowait set and we
can't try lock the delayed ref head's mutex, returning -EAGAIN with the
goal of making a write fallback to a blocking context. However we ignore
the -EAGAIN at btrfs_cross_ref_exist() when check_delayed_ref() returns
it, and keep looping instead of immediately returning the -EAGAIN to the
caller.
Fix this by not looping if we get -EAGAIN and we have a nowait path.
Fixes: 26ce91144631 ("btrfs: make can_nocow_extent nowait compatible")
CC: stable@vger.kernel.org # 6.1+
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/extent-tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 412e318e4a22..bd09dd3ad1a0 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -2422,7 +2422,7 @@ int btrfs_cross_ref_exist(struct btrfs_root *root, u64 objectid, u64 offset, goto out; ret = check_delayed_ref(root, path, objectid, offset, bytenr); - } while (ret == -EAGAIN); + } while (ret == -EAGAIN && !path->nowait); out: btrfs_release_path(path); |