summaryrefslogtreecommitdiffstats
path: root/fs/nfsd/nfssvc.c
diff options
context:
space:
mode:
authorJeff Layton <jlayton@primarydata.com>2014-07-30 03:34:42 +0200
committerJ. Bruce Fields <bfields@redhat.com>2014-07-31 20:20:31 +0200
commitd83017f94c290c56010e194cdbc45e59894ccae2 (patch)
treeae43a5fec20167258716bf8344e03c30006e0084 /fs/nfsd/nfssvc.c
parentnfsd: reduce cl_lock thrashing in release_openowner (diff)
downloadlinux-d83017f94c290c56010e194cdbc45e59894ccae2.tar.xz
linux-d83017f94c290c56010e194cdbc45e59894ccae2.zip
nfsd: don't thrash the cl_lock while freeing an open stateid
When we remove the client_mutex, we'll have a potential race between FREE_STATEID and CLOSE. The root of the problem is that we are walking the st_locks list, dropping the spinlock and then trying to release the persistent reference to the lockstateid. In between, a FREE_STATEID call can come along and take the lock, find the stateid and then try to put the reference. That leads to a double put. Fix this by not releasing the cl_lock in order to release each lock stateid. Use put_generic_stateid_locked to unhash them and gather them onto a list, and free_ol_stateid_reaplist to free any that end up on the list. Signed-off-by: Jeff Layton <jlayton@primarydata.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfssvc.c')
0 files changed, 0 insertions, 0 deletions