diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2023-11-30 19:45:28 +0100 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2023-12-07 03:45:15 +0100 |
| commit | 3dd75c8db1c1675a26d3e228bab349c1fc065867 (patch) | |
| tree | 902c260865c8e85da5a52179ae7b073616b8db0f /fs/xfs/xfs_bmap_item.c | |
| parent | xfs: don't set XFS_TRANS_HAS_INTENT_DONE when there's no ATTRD log item (diff) | |
| download | linux-3dd75c8db1c1675a26d3e228bab349c1fc065867.tar.xz linux-3dd75c8db1c1675a26d3e228bab349c1fc065867.zip | |
xfs: hoist intent done flag setting to ->finish_item callsite
Each log intent item's ->finish_item call chain inevitably includes some
code to set the dirty flag of the transaction. If there's an associated
log intent done item, it also sets the item's dirty flag and the
transaction's INTENT_DONE flag. This is repeated throughout the
codebase.
Reduce the LOC by moving all that to xfs_defer_finish_one.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_bmap_item.c')
| -rw-r--r-- | fs/xfs/xfs_bmap_item.c | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/fs/xfs/xfs_bmap_item.c b/fs/xfs/xfs_bmap_item.c index bd8f6fe22b40..913315cb5123 100644 --- a/fs/xfs/xfs_bmap_item.c +++ b/fs/xfs/xfs_bmap_item.c @@ -249,21 +249,7 @@ xfs_trans_log_finish_bmap_update( struct xfs_bud_log_item *budp, struct xfs_bmap_intent *bi) { - int error; - - error = xfs_bmap_finish_one(tp, bi); - - /* - * Mark the transaction dirty, even on error. This ensures the - * transaction is aborted, which: - * - * 1.) releases the BUI and frees the BUD - * 2.) shuts down the filesystem - */ - tp->t_flags |= XFS_TRANS_DIRTY | XFS_TRANS_HAS_INTENT_DONE; - set_bit(XFS_LI_DIRTY, &budp->bud_item.li_flags); - - return error; + return xfs_bmap_finish_one(tp, bi); } /* Sort bmap intents by inode. */ |