summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorHe Wang <xw897002528@gmail.com>2025-01-06 04:39:54 +0100
committerSteve French <stfrench@microsoft.com>2025-01-08 00:29:17 +0100
commit2ac538e40278a2c0c051cca81bcaafc547d61372 (patch)
tree6c2d8ed2eec5f5cc2d6bcb16d01a57796cc5ca74 /fs
parentksmbd: Remove unneeded if check in ksmbd_rdma_capable_netdev() (diff)
downloadlinux-2ac538e40278a2c0c051cca81bcaafc547d61372.tar.xz
linux-2ac538e40278a2c0c051cca81bcaafc547d61372.zip
ksmbd: fix unexpectedly changed path in ksmbd_vfs_kern_path_locked
When `ksmbd_vfs_kern_path_locked` met an error and it is not the last entry, it will exit without restoring changed path buffer. But later this buffer may be used as the filename for creation. Fixes: c5a709f08d40 ("ksmbd: handle caseless file creation") Signed-off-by: He Wang <xw897002528@gmail.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/smb/server/vfs.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index 88d167a5f8b7..40f08eac519c 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -1264,6 +1264,8 @@ int ksmbd_vfs_kern_path_locked(struct ksmbd_work *work, char *name,
filepath,
flags,
path);
+ if (!is_last)
+ next[0] = '/';
if (err)
goto out2;
else if (is_last)
@@ -1271,7 +1273,6 @@ int ksmbd_vfs_kern_path_locked(struct ksmbd_work *work, char *name,
path_put(parent_path);
*parent_path = *path;
- next[0] = '/';
remain_len -= filename_len + 1;
}