diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2024-03-02 15:18:27 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-03-06 04:07:13 +0100 |
| commit | 344f7a4651497ffc62166ec6318b33f79d71c3df (patch) | |
| tree | 06554963f9cfd567f956107eda96c76e592b3ddd /include/net/eee.h | |
| parent | sock: Use unsafe_memcpy() for sock_copy() (diff) | |
| download | linux-344f7a4651497ffc62166ec6318b33f79d71c3df.tar.xz linux-344f7a4651497ffc62166ec6318b33f79d71c3df.zip | |
ethtool: ignore unused/unreliable fields in set_eee op
This function is used with the set_eee() ethtool operation. Certain
fields of struct ethtool_keee() are relevant only for the get_eee()
operation. In addition, in case of the ioctl interface, we have no
guarantee that userspace sends sane values in struct ethtool_eee.
Therefore explicitly ignore all fields not needed for set_eee().
This protects from drivers trying to use unchecked and unreliable
data, relying on specific userspace behavior.
Note: Such unsafe driver behavior has been found and fixed in the
tg3 driver.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/ad7ee11e-eb7a-4975-9122-547e13a161d8@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net/eee.h')
0 files changed, 0 insertions, 0 deletions