diff options
| author | David Howells <dhowells@redhat.com> | 2024-12-16 21:34:45 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-20 22:07:58 +0100 |
| commit | d4e338de17cb6532bf805fae00db8b41e914009b (patch) | |
| tree | cd764e0e14cf605fdad2677f45a50408e57dac81 /include | |
| parent | netfs: Fix the (non-)cancellation of copy when cache is temporarily disabled (diff) | |
| download | linux-d4e338de17cb6532bf805fae00db8b41e914009b.tar.xz linux-d4e338de17cb6532bf805fae00db8b41e914009b.zip | |
netfs: Fix is-caching check in read-retry
netfs: Fix is-caching check in read-retry
The read-retry code checks the NETFS_RREQ_COPY_TO_CACHE flag to determine
if there might be failed reads from the cache that need turning into reads
from the server, with the intention of skipping the complicated part if it
can. The code that set the flag, however, got lost during the read-side
rewrite.
Fix the check to see if the cache_resources are valid instead. The flag
can then be removed.
Fixes: ee4cdf7ba857 ("netfs: Speed up buffered reading")
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/3752048.1734381285@warthog.procyon.org.uk
cc: Jeff Layton <jlayton@kernel.org>
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/netfs.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/netfs.h b/include/linux/netfs.h index 4083d77e3f39..ecdd5ced16a8 100644 --- a/include/linux/netfs.h +++ b/include/linux/netfs.h @@ -269,7 +269,6 @@ struct netfs_io_request { size_t prev_donated; /* Fallback for subreq->prev_donated */ refcount_t ref; unsigned long flags; -#define NETFS_RREQ_COPY_TO_CACHE 1 /* Need to write to the cache */ #define NETFS_RREQ_NO_UNLOCK_FOLIO 2 /* Don't unlock no_unlock_folio on completion */ #define NETFS_RREQ_DONT_UNLOCK_FOLIOS 3 /* Don't unlock the folios on completion */ #define NETFS_RREQ_FAILED 4 /* The request failed */ |